Ts components #41
Open
Ts components #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added vue-property-decorator package - added vuex-class package
- removed optimize three plugin b/c it's incompatible with type - updated files affected by plugin removal
|
Added automatic debounced search activation when a search option on the browse page changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted components to typescript to support long-term maintenance. Added type declarations and additional comments to variables and functions to make it easier to understand how to utilize them. Also added jsdoc comments and type annotations in JavaScript utility files for compatibility with the typescript components and other TypeScript utility files.
Hopefully this makes it easier to get open source contributions since more people will understand the types if they're more explicit.