Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding Issues to Address #3

Open
6 of 11 tasks
spencer516 opened this issue Dec 30, 2016 · 0 comments
Open
6 of 11 tasks

Outstanding Issues to Address #3

spencer516 opened this issue Dec 30, 2016 · 0 comments

Comments

@spencer516
Copy link
Collaborator

spencer516 commented Dec 30, 2016

Open Questions:

  • Is the .css-compose file extension the right route to go? What are the pros/cons?
  • Is the @compose with nested @ sufficient?
  • What happens when we want to use dynamically generated class names? (this is possible, it just needs to be properly documented when/why).
  • What versions of Ember does this work with? (It's untested against everything except 2.10)
  • Need to support back to node 0.12 (probably not necessary).
  • this should not be a relative path
  • this should also probably not be hard-coded.
  • What do we do about composes definitions that are declared multiple times? And, what are the ordering concerns, if any, we need to think about?

Possible Improvements / Ideas

  • What are the possible errors or easy mistakes people might make if they're using this?
  • If we're doing a production build, can we remove the _classify hooks/helpers so that a string is replaced wholly with another string? (Will that even matter? ¯_(ツ)_/¯)
  • Since creates an "adapter" between the CSS from the JS, what other things can we do to analyze/transform the CSS so that it does not break the app? (e.g.: removing unused styles, merging repeated styles, minifying class names?)
spencer516 added a commit that referenced this issue Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant