Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somehow localize membership type text #13

Open
MikaelSiidorow opened this issue Jan 28, 2025 · 0 comments
Open

Somehow localize membership type text #13

MikaelSiidorow opened this issue Jan 28, 2025 · 0 comments

Comments

@MikaelSiidorow
Copy link
Collaborator

MikaelSiidorow commented Jan 28, 2025

Membership type is now stored in the database in a type column with type text:

export const membership = pgTable("membership", {
	id: text("id").primaryKey(),
	type: text("type").notNull(), // TODO: l10n
	/* ... */
});

We could probably do any of the following

  1. Keep it as is and don't translate to English
  2. Change type to an enum and require code changes to add a new membership type
  3. Add another column for type_en for the English translation
  4. ...something else?

We also need to be mindful of which is the primary type field, since the current plan is to connect memberships by the type field (renew notifications etc.)

@MikaelSiidorow MikaelSiidorow converted this from a draft issue Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant