Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: encode filenames before posting to laskugeneraattori #523

Closed
wants to merge 614 commits into from
Closed

fix: encode filenames before posting to laskugeneraattori #523

wants to merge 614 commits into from

Conversation

MikaelSiidorow
Copy link
Collaborator

Description

  • fix: encode filenames before posting to laskugeneraattori

Closes #522

Before submitting the PR, please make sure you do the following

  • If your PR is related to a previously discussed issue, please link to it here.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Make sure the commit history is linear, up-to-date with main branch and does not contain any erroneous changes

Formatting and linting

  • Format code with pnpm format and lint the project with pnpm lint

MikaelSiidorow and others added 30 commits May 18, 2024 15:05
@MikaelSiidorow
export weekly newsletters data
0fca045
@MikaelSiidorow
refactor fetcher to add globalOpts and put sorting there
4883b4f
@MikaelSiidorow
revalidate weekly newsletters on save
b96b9bb
@MikaelSiidorow
simplify special pages to be inluded under page types
d64682a
@jaakkonakaza
Dynamic hero text (#311)
d3800d8 
* Make hero text dynamic and add cool animation (#290)

* Remove unused import

* Fix code review comments
@MikaelSiidorow
Fix landing page event list page
9b3fb4b
@MikaelSiidorow
do not localize news item categories, default to guild
604023e
@MikaelSiidorow
regen payload times
05e18be
@MikaelSiidorow
move announcement card chevron to right
775f39f
@joonatanaatos @MikaelSiidorow
chore: Update db table names
cc109e5
@MikaelSiidorow
add typechecking to CI, skip linting and typechecking in next build
d7b4c06
@MikaelSiidorow
add optional photographer field to media, show in landing page
9a1184e
@MikaelSiidorow
hide landing page image photographer from non-active image
a231754
@samuliys
Make site logo changeable through CMS (#316)
c2adb0f 
* add dynamic site logo

* add site logo

* improve code quality
@anolpe
add Alkorytmi page
ca9a729
@MikaelSiidorow
sort committees alphabetically
97ff239
@MikaelSiidorow
add skip to main content button
817f26b
@MikaelSiidorow
add image link grid block for partners
00efc53
@MikaelSiidorow
add some more partners for mock testing
d9ce031
@joonatanaatos
feat: improve mobile layout
4cb1530
@lakaniemi
Fix issue with mobile navigation cutting off from the bottom (#328)
3fd2cd4
@MikaelSiidorow
improve link text on screen readers
84ada93
@MikaelSiidorow
fix(splash text): add max width, clamp to 4 lines, break words
9e3e423
@MikaelSiidorow
improve responsiveness with document cards, committes, magazines and …
67ed4ca 
…boards
@MikaelSiidorow
add main partners text to footer, add main partners to bottom of mobi…
34070a8 
…le nav
@MikaelSiidorow
update active link styling, more space in mobile nav links
ec8620c
@MikaelSiidorow
nicer text spacing in table of contents
f8e13ad
@MikaelSiidorow
optimize hero image loading
8f415fa
@MikaelSiidorow
truncate cms image width and height to integers
acd0db5
@MikaelSiidorow
fix invalid nesting in main nav
e8dc0d5
MikaelSiidorow and others added 17 commits September 21, 2024 19:26
@MikaelSiidorow
fix: disable sign up editing and deletion if event sign ups are closed
7a15b5d
@Mikmokki
Modify mail sending routes to be entirely on backend
a864de9
@Mikmokki
Add order numbers for headers
3dd2e33
@Mikmokki
Add inter font to email
c7639c6
@MikaelSiidorow
feat: add external link ctaType to news
bc1af6a
@emiliarepo
Feat: Badges of honor (#515)
e639111 
Add support for badges of honor
@MikaelSiidorow
fix: try to tweak calendar intergration cache options
35f22ea
@MikaelSiidorow
fix: tweak ics integration config
ae6de5d
@MikaelSiidorow
fix: fold ics url text
f789ad0
@MikaelSiidorow
fix: remove unnecessary console.log
2b634af
@MikaelSiidorow
chore: update deps
1eb5d67
@MikaelSiidorow
fix: form actions without state must return void
44626fe
@MikaelSiidorow
fix: autofix linting issues
b6699f0
@IiroP @joonatanaatos
fix: Load VT323 font for Teemu Teekkari game (#517)
958d0e7
@MikaelSiidorow
feat: update eslint v9
fbabb59
@MikaelSiidorow
fix: next-env.d.ts should be checked out in git
b404712
@MikaelSiidorow
fix: encode filenames before posting to laskugeneraattori
e1057c7
@MikaelSiidorow MikaelSiidorow requested a review from IiroP October 14, 2024 11:55
@MikaelSiidorow MikaelSiidorow linked an issue Oct 14, 2024 that may be closed by this pull request
Handle åäö in filenames (Invoice Generator front) #522
Open
IiroP
IiroP requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@IiroP IiroP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work (at least without changes to backend)

image

@MikaelSiidorow MikaelSiidorow mentioned this pull request Oct 14, 2024
Open
@lajp
Copy link
Member

lajp commented Oct 15, 2024

I'm not sure how it is done right now but apparently non-ascii characters are to be included, they should be added to the filename* field with the RFC 5987 encoding

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#syntax

You may want to avoid percent escape sequences in filename, because they are handled inconsistently across browsers.

@MikaelSiidorow
Copy link
Collaborator Author

I'm not sure how it is done right now but apparently non-ascii characters are to be included, they should be added to the filename* field with the RFC 5987 encoding

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#syntax

You may want to avoid percent escape sequences in filename, because they are handled inconsistently across browsers.

@lajp I'll take a look. We are using a higher level abstraction with FormData and Fetch, that should do the right thing automatically...

@lajp
Copy link
Member

lajp commented Oct 16, 2024

I found a potential cause for this. Apparently multer, the crate used by axum::extract::Multipart doesn't support the filename*-field: rwf2/multer#52

@MikaelSiidorow
Copy link
Collaborator Author

We could also just slugify the original filenames and strip special characters as a workaround, I doubt that would affect any invoices negatively 🤔 Could do it in similarly like we do with heading IDs for rich text

@kahlstrm kahlstrm closed this Feb 4, 2025
@MikaelSiidorow MikaelSiidorow mentioned this pull request Feb 4, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IiroP IiroP IiroP requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle åäö in filenames (Invoice Generator front)