-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binding for tiledb_array_consolidate_fragments. #322
Merged
shaunrd0
merged 5 commits into
master
from
smr/sc-49723/add-array-consolidate-fragments
Jul 19, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
12e0bcd
Add binding for tiledb_array_consolidate_fragments.
shaunrd0 dcbc6ed
Fix test.
shaunrd0 0e1a439
Remove TODO and update test.
shaunrd0 2e35c1f
Skip test pending core relase with fix.
shaunrd0 40f7cbf
Changes from review.
shaunrd0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
package tiledb | ||
|
||
/* | ||
#include <stdlib.h> | ||
*/ | ||
import "C" | ||
import ( | ||
"reflect" | ||
"unsafe" | ||
|
@@ -20,3 +24,18 @@ func slicePtr[T any](slc []T) unsafe.Pointer { | |
hdr := (*reflect.SliceHeader)(unsafe.Pointer(&slc)) | ||
return unsafe.Pointer(hdr.Data) | ||
} | ||
|
||
// cStringArray takes an array of Go strings and converts it to an array of CStrings. | ||
// The function returned should be deferred by the caller to free allocated memory. | ||
func cStringArray(stringList []string) ([]*C.char, func()) { | ||
list := make([]*C.char, len(stringList)) | ||
for i, str := range stringList { | ||
list[i] = C.CString(str) | ||
} | ||
|
||
return list, func() { | ||
for _, str := range list { | ||
C.free(unsafe.Pointer(str)) | ||
} | ||
} | ||
} | ||
Comment on lines
+28
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like this a lot. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the function
createTestArray
would be visible to all tests in this package, it might be worth making the name more specific, since the array created may not be suitable for all tests. maybecreate1DTestArray
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done