-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with regex used to identify clickhouse error messages #104
Comments
@TimonKK is there any reason we need to keep the |
I see you updated here in September, can we drop the # check? |
What do you mean about "drop the # check"? |
@TimonKK the current regex is checking if there are numbers ( |
I know ClickHouse has two digital error codes, for example, ClickHouse/ClickHouse#33839. So I think to adjust regexp to '(Code|Error): ([0-9]{2,})[,.] .*Exception: (.+?)$' |
@TimonKK The problem is there are now three digit error codes, e.g. I got |
I understood about three-digit error codes. And I suggested new regexp /(Code|Error): ([0-9]{2,})[,.] .*Exception: (.+?)$/. You could test it on https://regexr.com/ |
The regex used to catch error messages from the clickhouse server is missing error codes with 3 digits e.g. error code 215. The change below would fix it, but I don't know clickhouse well enough to determine if this will cause other issues.
The text was updated successfully, but these errors were encountered: