Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #216

Open
elfring opened this issue Apr 28, 2019 · 1 comment
Open

reserved identifier violation #216

elfring opened this issue Apr 28, 2019 · 1 comment

Comments

@elfring
Copy link

elfring commented Apr 28, 2019

I would like to point out that an identifier like “_H_TIRAMISU_CORE_” does eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@rbaghdadi
Copy link
Collaborator

Hi @elfring , thanks. Good catch. Yes I agree.
If you want to send a pull request this, we will be happy to accept it. There are few header files only, so it should not be a big trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @rbaghdadi