Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest creating "Description:" heading in Event details modal. #307

Open
intelagense opened this issue Jan 31, 2023 · 4 comments
Open

Suggest creating "Description:" heading in Event details modal. #307

intelagense opened this issue Jan 31, 2023 · 4 comments
Labels
Accessibility Issues impacting the accessibility of the project enhancement New feature or request Good 100Devs First Try Great first issue for 100Devs Members

Comments

@intelagense
Copy link
Member

Please provide a summary of the feature

image

The event details modal inserts the word "Description: " as additional text before the actual description from the event creator. Semantically it would be better to include this in a heading tag, preferably above the text box area.

This would also improve the user experience when recreating events. Currently, when copying and pasting a previous event description in order to recreate a new event description the "Description:" can be copied and inadvertently duplicated as well.

Example:

"Description: Description: An event where people gather to do things."

Are there any potential issues you foresee with this feature

Aesthetics in regards to #17 👀

Is this feature related to any current or past issues? Please provide the

Additional context

Add any other context or screenshots about the feature request here.

Which Branch should this fix be Pulled into?

PR into [branchName]

If you're interested in working on this feature, please comment so you can be assigned

@intelagense intelagense added enhancement New feature or request Accessibility Issues impacting the accessibility of the project labels Jan 31, 2023
@intelagense
Copy link
Member Author

@Caleb-Cohen
Copy link
Member

Just a heads up this has been solved in a future redesign in #285. Redesign will probably take some time so if someone wanted to take this on it will be available until #285 is pulled into development.

@Caleb-Cohen Caleb-Cohen moved this to In Progress in Together Post-MVP Release Feb 2, 2023
@Caleb-Cohen Caleb-Cohen moved this from In Progress to Todo in Together Post-MVP Release Feb 2, 2023
@Caleb-Cohen Caleb-Cohen added the Good 100Devs First Try Great first issue for 100Devs Members label Jul 25, 2023
@vguzman812
Copy link
Contributor

Hi. This seems like an easy fix. I would like to be assigned this if possible. I already have a solved branch ready that will close this issue.

vguzman812 added a commit to vguzman812/Together that referenced this issue Aug 19, 2023
…iption. Change margin classes of description div and the description heading to better reflect desired layout found in issue examples. Solves issue Together-100Devs#307.
@vguzman812 vguzman812 mentioned this issue Aug 21, 2023
13 tasks
Caleb-Cohen pushed a commit that referenced this issue Aug 21, 2023
* Move description of event modal into an h3 tag outside of modal description. Change margin classes of description div and the description heading to better reflect desired layout found in issue examples. Solves issue #307.

* change span to h3 for modal description
@cblanken
Copy link
Contributor

This issue should be closed. It was resolved by PR #444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues impacting the accessibility of the project enhancement New feature or request Good 100Devs First Try Great first issue for 100Devs Members
Projects
Development

No branches or pull requests

4 participants