Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create event modal fails to reset without user input #425

Open
intelagense opened this issue Jul 9, 2023 · 5 comments
Open

Create event modal fails to reset without user input #425

intelagense opened this issue Jul 9, 2023 · 5 comments
Assignees
Labels
bug Something isn't working Frontend Low Priority This is for issues that may or may not be important, and do not need to be solved quickly.

Comments

@intelagense
Copy link
Member

intelagense commented Jul 9, 2023

Describe the bug

After creating an event, a success message is displayed along with an option to create another event. If the user instead closes the modal and reopens it using the plus icon on any day or the "add event" button, the modal continues to display the success message and the option to create another event instead of resetting its state.

To Reproduce

Steps to reproduce the behavior:

  1. Create any successful event.
  2. Close the modal by clicking close or clicking outside of the modal.
  3. Attempt to create a new event.
  4. When the modal reopens, notice it displays the previous success message.

You will need to click on "New Event" to proceed with creating a new event.

Expected behavior

After creating an event and closing the modal, the modal should reset when reopened. It should no longer display the previous success message with the option to create another event. The modal should return to its initial state, ready for a new event creation process. The current behavior can confuse users who need to enter multiple events in the same session.

Screenshots

success screen of modal

Which Branch should this fix be Pulled into?

PR into [branchName]

Device Information

N/A

Additional context

N/A

@intelagense intelagense added bug Something isn't working Frontend labels Jul 9, 2023
@dreymoreau
Copy link

dreymoreau commented Jul 10, 2023

hey, could be interested in trying to tackle this, what would be the timeframe for completing?

@intelagense intelagense added the Low Priority This is for issues that may or may not be important, and do not need to be solved quickly. label Jul 12, 2023
@intelagense
Copy link
Member Author

@dreymoreau I have assigned it to you and added the 'Low Priority' tag. Feel free to take a look at it when you have a chance and see what you can find out.

@romanstetsyk
Copy link
Contributor

Hi @intelagense, can I take this issue?

@intelagense
Copy link
Member Author

Sure!

@romanstetsyk
Copy link
Contributor

While working on this, I found the following bug in the event form where date validation is not triggered:

Screen.Recording.2023-08-15.at.3.21.11.AM.mov

Should we create a separate issue for it and reset the form only if the event has been successfully added? Or reset the form every time it is closed, which will solve both the current issue and the bug above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend Low Priority This is for issues that may or may not be important, and do not need to be solved quickly.
Projects
None yet
Development

No branches or pull requests

3 participants