Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial "Login to Discord" leads back to unrefreshed Together home page #430

Open
macauleydev opened this issue Jul 12, 2023 · 8 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@macauleydev
Copy link

Describe the bug

On my first visit to the Together website, after clicking "Login to Discord" and logging in and granting access, the browser took me back to the Together homepage with both login buttons unchanged ("Login" and "Login to Discord").

To Reproduce

I have not yet been able to reproduce this bug.

Things I tried:

  • Deauthorize "Together Site" in Discord app
  • Sign out of Discord in browser (so that next sign-in includes 2fa prompt)
  • Clear browser cookies for together.cyclic.app and discord.com
  • Disable setting where Firefox automatically opens discord links in Discord app

Expected behavior

The login buttons on the Together homepage should reflect login status (by changing to "Logout" after successful login). (This happened correctly on all login attempts after the first.)

Redirection to the calendar (and display of a welcome message) appears to be another intended result of successful login.

Screenshots

(none yet)

Which Branch should this fix be Pulled into?

(none yet)

Device Information

Desktop:

  • macOS 13.4.1
  • Firefox 115.0.1

Additional context

(none yet)

If you're interested in working on this feature, please comment so you can be assigned

@macauleydev macauleydev added the bug Something isn't working label Jul 12, 2023
@Caleb-Cohen
Copy link
Member

Caleb-Cohen commented Jul 12, 2023

Thanks for pointing this out! Is this happening to you in production or development? I'm unable to reproduce in either, but this would coincide with the routing update.

@macauleydev
Copy link
Author

It happened for me on https//together.cyclic.app.

So far, it's not a big deal, but I figured I'd open the issue in case it happens for other new users.

@Caleb-Cohen
Copy link
Member

It happened for me on https//together.cyclic.app.

So far, it's not a big deal, but I figured I'd open the issue in case it happens for other new users.

No errors or anything in the console?

@guel-codes
Copy link
Contributor

@Caleb-Cohen I think this is still happening. The redirect is failing for me and I'm getting a connection failed / callback error:

image

@MingJae92
Copy link

Hi there,

I would like to fix this issue. Please may I be assigned? I am still pretty new to OS, so please bare with me.

Kind regards

Ming Chi

@intelagense
Copy link
Member

Let's go! @MingJae92

@MingJae92
Copy link

What are the steps to view this issue? I am quite new tot this.

@intelagense
Copy link
Member

intelagense commented Nov 24, 2023

@MingJae92 The original issue was that when you logged in, it would take you back to the landing page and the login button would be in the wrong state. Right now that is working for me, but see if it breaks for you.

I think the other part is that it should redirect to https://together.cyclic.app/calendar after a successful login instead of going back to the landing page and that is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants