Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect users from accessing /adminDashboard #439

Open
Caleb-Cohen opened this issue Aug 1, 2023 · 6 comments
Open

Protect users from accessing /adminDashboard #439

Caleb-Cohen opened this issue Aug 1, 2023 · 6 comments
Assignees
Labels

Comments

@Caleb-Cohen
Copy link
Member

Caleb-Cohen commented Aug 1, 2023

Please provide a summary of the feature

Currently admin dashboard can be access using React Router by appending /adminDashboard to the end. We want to prevent users from access adminDashboard. Ideally, it blocks the user on request instead of redirecting them once they land on the page.

Depends on

#441

Is this feature related to any current or past issues? Please provide the

Additional context

This is a tough cookie. React router seems a little restrictive with our options considering the current app design.

Add any other context or screenshots about the feature request here.

If you're interested in working on this feature, please comment so you can be assigned

@cblanken
Copy link
Contributor

cblanken commented Aug 3, 2023

I'd like to take another look at this, but if I haven't gotten anywhere by the weekend, someone should feel free to pick it up.

@r-Dev03
Copy link
Contributor

r-Dev03 commented Aug 10, 2023

When you say "block them" what are you exactly referring to? Do you mean send them to a page that notifies them that only admin's can access that page? That would be considered some form of "blocking"

@Caleb-Cohen
Copy link
Member Author

When you say "block them" what are you exactly referring to? Do you mean send them to a page that notifies them that only admin's can access that page? That would be considered some form of "blocking"

I've kept it vague as I'm not familiar with all our options. Ideally, un-authorized users will not have access to the /Admindashboard page. Any attempt to access will redirect back to homepage, without accessing any part of the page.

@r-Dev03
Copy link
Contributor

r-Dev03 commented Aug 14, 2023

Hmm, sounds good, I can take a crack at it if don't mind assigning me

@Caleb-Cohen
Copy link
Member Author

Hmm, sounds good, I can take a crack at it if don't mind assigning me

assigned!

@Caleb-Cohen
Copy link
Member Author

On hold for #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants