Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have hdf5_attrs as attribute to HDF5InputDialog #452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DanicaSTFC
Copy link
Collaborator

@DanicaSTFC DanicaSTFC commented Jan 30, 2025

Describe your changes

  • Have hdf5_attrs as attribute to HDF5InputDialog

Describe any testing you have performed

Ran tests locally: 60 passed

Link relevant issues

Closes #453

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the CIL developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'waiting for review'

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Qt contributions should follow Qt naming conventions i.e. camelCase method names.

VTK contributions should follow VTK naming conventions i.e. PascalCase method names.

@DanicaSTFC DanicaSTFC self-assigned this Jan 30, 2025
@DanicaSTFC DanicaSTFC requested a review from paskino January 30, 2025 14:21
@DanicaSTFC DanicaSTFC added this to the Version 25.0.0 milestone Jan 30, 2025
@DanicaSTFC DanicaSTFC marked this pull request as ready for review January 30, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Need access to hdf5_attrs in HDF5InputDialog
1 participant