Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gymnasium 1.0 #212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Support gymnasium 1.0 #212

wants to merge 1 commit into from

Conversation

Jendker
Copy link

@Jendker Jendker commented Oct 15, 2024 •
edited
Loading

This adds changes required to support gymnasium 1.0.
Tested with PPO and observed no regression in the learning quality and performance.

Please let me know if you have any suggestions.

@Jendker Jendker changed the base branch from main to develop October 15, 2024 15:47
@Jendker
Copy link
Author

Jendker commented Oct 15, 2024 •
edited
Loading

Since make_vec defaults to sync mode as per docs: https://github.com/Farama-Foundation/Gymnasium/blob/d571ed63017fb0bf1a9022960a3798b8d7c8b409/gymnasium/envs/registration.py#L849-L851 I have removed the synchronous argument from make_vec to make the code less verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jendker