From fa32bb8dc63faf6c606d723c0c89d3021b132a18 Mon Sep 17 00:00:00 2001
From: Daryl Lim <daryllimyt@gmail.com>
Date: Sun, 24 Mar 2024 04:00:03 -0700
Subject: [PATCH] feat(engine): Add logging when run status changes

---
 tracecat/runner/actions.py   | 2 ++
 tracecat/runner/app.py       | 1 +
 tracecat/runner/workflows.py | 1 +
 3 files changed, 4 insertions(+)

diff --git a/tracecat/runner/actions.py b/tracecat/runner/actions.py
index 54c7b0af6..1a34c2197 100644
--- a/tracecat/runner/actions.py
+++ b/tracecat/runner/actions.py
@@ -881,6 +881,7 @@ async def run_action(
 # TODO: Move these calls into a logger
 async def log_create_action_run(action_run: ActionRun) -> ActionRunResponse:
     """Create a workflow run."""
+    logger.info(f"Log create action run {action_run.id}")
     action_id = action_key_to_id(action_run.action_key)
     params = CreateActionRunParams(
         action_run_id=action_run.id,
@@ -896,6 +897,7 @@ async def log_create_action_run(action_run: ActionRun) -> ActionRunResponse:
 
 async def log_update_action_run(action_run: ActionRun, *, status: RunStatus) -> None:
     """Update a workflow run."""
+    logger.info(f"Log update action run {action_run.id} with status {status}.")
     action_id = action_key_to_id(action_run.action_key)
     params = UpdateActionRunParams(status=status)
     async with AuthenticatedAPIClient(http2=True) as client:
diff --git a/tracecat/runner/app.py b/tracecat/runner/app.py
index 8108e53a4..8b04b0398 100644
--- a/tracecat/runner/app.py
+++ b/tracecat/runner/app.py
@@ -402,6 +402,7 @@ async def run_workflow(
         for running_task in running_jobs_store.values():
             running_task.cancel()
 
+    # TODO: Update this to update with status 'failure' if any action fails
     await update_workflow_run(
         workflow_id=workflow_id, workflow_run_id=workflow_run_id, status=run_status
     )
diff --git a/tracecat/runner/workflows.py b/tracecat/runner/workflows.py
index dd8c19a2a..24a2ba7ee 100644
--- a/tracecat/runner/workflows.py
+++ b/tracecat/runner/workflows.py
@@ -149,6 +149,7 @@ async def update_workflow_run(
     status: RunStatus,
 ) -> None:
     """Update a workflow run."""
+    logger.info(f"Log update workflow run {workflow_run_id} with status {status}")
     params = UpdateWorkflowRunParams(status=status)
     async with AuthenticatedAPIClient(http2=True) as client:
         response = await client.post(