Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gem to manage dependencies and fine tuned styles. #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nobuti
Copy link
Contributor

@nobuti nobuti commented Feb 7, 2015

This PR fixes #78.

I've added locales and tweak styles a bit to fit in the look and feel. Please, check these are ok and feel free to propose any change.

@nobuti
Copy link
Contributor Author

nobuti commented Feb 7, 2015

It seems waffle doesn't understand «implements» to link the PR to the issue. Fixed with «fixes».

@furilo
Copy link
Member

furilo commented Feb 7, 2015

Hey, thanks! I told @ferblape once in person that we might want to wait to implement this until we get some legal form for the project, because I think the privacy statement and cookie policy should be linked, and we don't have that yet without legal form ;)

And for the time being, as we are not using yet any third party service, it seems we are not yet obliged to display the warning:

Cookies clearly exempt from consent according to the EU advisory body on data protection- WP29pdf include:
user‑input cookies (session-id) such as first‑party cookies to keep track of the user's input when filling online forms, shopping carts, etc., for the duration of a session or persistent cookies limited to a few hours in some cases
authentication cookies, to identify the user once he has logged in, for the duration of a session
user‑centric security cookies, used to detect authentication abuses, for a limited persistent duration
multimedia content player cookies, used to store technical data to play back video or audio content, for the duration of a session
load‑balancing cookies, for the duration of session
user‑interface customisation cookies such as language or font preferences, for the duration of a session (or slightly longer)
third‑party social plug‑in content‑sharing cookies, for logged‑in members of a social network.

from: http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm

So should we wait to merge this?

@nobuti
Copy link
Contributor Author

nobuti commented Feb 7, 2015

Oops, I saw the «ready to implement» label, and I went for it. Sorry about the noise.
I agree, we should wait. The implementation is not a big deal, and we probably will need to adapt the styles to the new design, so 👍 to leave it for now.

@furilo
Copy link
Member

furilo commented Feb 7, 2015

Yeah, our fault for not having that correctly tagged :S

Conflicts:
	Gemfile
	app/assets/javascripts/application.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify about the cookies
2 participants