Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom empty element tag closing #36

Closed
ethanjurman opened this issue Oct 6, 2017 · 3 comments
Closed

Support for custom empty element tag closing #36

ethanjurman opened this issue Oct 6, 2017 · 3 comments

Comments

@ethanjurman
Copy link
Contributor

https://developer.mozilla.org/en-US/docs/Glossary/Empty_element

It's redundant and obnoxious to close custom elements that do not take in or make use of children elements. @JRJurman is this possible?

@JRJurman
Copy link
Member

JRJurman commented Oct 7, 2017

We should definitely look into this... The issue is either in https://github.com/Tram-One/bel-create-element or in https://github.com/aaaristo/rbel

@ethanjurman
Copy link
Contributor Author

We could provide a function that checks for nested tags and properly closes them before sending to bel / rbel... but then the question is whether we are sacrificing performance for what would be a less than optimal solution.

Actually would the performance there really matter?

@JRJurman
Copy link
Member

turns out it was hyperx, pr in the works: choojs/hyperx#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants