Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriBITS not catching a circular dependency between a subpackage and its parent package #556

Open
bartlettroscoe opened this issue Dec 23, 2022 · 0 comments

Comments

@bartlettroscoe
Copy link
Member

Description

The PR trilinos/Trilinos#1142 where the thyra/core/cmake/Dependencies.cmake file was updated to list a dependence of ThyraCore on its parent package Thyra shows that there is a missing check in TriBITS for an attempt to define a circular dependence of a subpackage on its parent package. (Because there is automatically a dependence of the parent package on eadh of its subpackages.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Selected
Development

No branches or pull requests

1 participant