Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

govern and simple-voter import fails due to old smart-wallet dependency #159

Open
secretshardul opened this issue Apr 3, 2022 · 0 comments

Comments

@secretshardul
Copy link

secretshardul commented Apr 3, 2022

Anchor version- 0.23.0

govern import breaks when smart-wallet v0.9.0 is compiled. Importing smart-wallet directly also gives the same error-

BPF SDK: /home/hp/.local/share/solana/install/releases/1.8.16/solana-release/bin/sdk/bpf
cargo-build-bpf child: rustup toolchain list -v
cargo-build-bpf child: cargo +bpf build --target bpfel-unknown-unknown --release
   Compiling smart-wallet v0.9.0
error[E0053]: method `validate` has an incompatible type for trait
  --> /home/hp/.cargo/registry/src/github.com-1ecc6299db9ec823/smart-wallet-0.9.0/src/instructions/buffer_append_ix.rs:45:27
   |
45 |     fn validate(&self) -> Result<()> {
   |                           ^^^^^^^^^^
   |                           |
   |                           expected enum `anchor_lang::error::Error`, found a different enum `anchor_lang::error::Error`
   |                           help: change the output type to match the trait: `std::result::Result<(), anchor_lang::error::Error>`
   |
   = note: expected fn pointer `fn(&buffer_append_ix::AppendBufferIX<'info>) -> std::result::Result<_, anchor_lang::error::Error>`
              found fn pointer `fn(&buffer_append_ix::AppendBufferIX<'info>) -> std::result::Result<_, anchor_lang::error::Error>`

The latest smart wallet version is 0.10.1, so we should bump up.

Edit- Addressed by #149. Merge is blocked due to a failing test

@secretshardul secretshardul changed the title govern and simple-voter import fails, bump up smart-wallet dependency govern and simple-voter import fails due to old smart-wallet dependency Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant