Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infura backend is not accepted #45

Closed
TripleSpeeder opened this issue Dec 10, 2019 · 1 comment · Fixed by #47
Closed

infura backend is not accepted #45

TripleSpeeder opened this issue Dec 10, 2019 · 1 comment · Fixed by #47
Labels
bug Something isn't working released

Comments

@TripleSpeeder
Copy link
Owner

connectionCheck-middleware currently uses npm package is-reachable to check if the provided web3 node is available. Unfortunately this fails for infura nodes, as they return a 404 which is interpreted as "fail" by is-reachable package. This is a known issue, see sindresorhus/is-reachable#39.
@TripleSpeeder TripleSpeeder added the bug Something isn't working label Dec 10, 2019
TripleSpeeder added a commit that referenced this issue Dec 10, 2019
@TripleSpeeder
fix: allow connecting to infura nodes
68fa986 
Use connectionTester instead of is-reachable to prevent false negatives when checking node connectivity.

This fixes #45
@TripleSpeeder TripleSpeeder mentioned this issue Dec 10, 2019
Merged
TripleSpeeder pushed a commit that referenced this issue Dec 10, 2019
@semantic-release-bot
chore(release): 1.5.1 [skip ci]
3b7bdcf 
## [1.5.1](v1.5.0...v1.5.1) (2019-12-10)

### Bug Fixes

* allow connecting to infura nodes ([68fa986](68fa986)), closes [#45](#45)
* process hangs when using websocket provider ([85a26ef](85a26ef)), closes [#46](#46)
@TripleSpeeder
Copy link
Owner Author

🎉 This issue has been resolved in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow connecting to infura nodes TripleSpeeder/ens-updater
1 participant
@TripleSpeeder