sdc-vmapi AddNics cannot accept ipv4_ips argument

[leeyc0]

reference: https://help.joyent.com/requests/186559

According to sdc-vmapi/blob/master/docs/index.md, the wording of networks argument in AddNics is "List of networks. Same format as CreateVm". This wording implies all parameters in the networks argument list is accepted, including ipv4_ips, however I found it is not working. After consulting your support, we are told that it is in fact not accepted, and I was told to open an issue to update the documentation here.

[rmustacc]

Thanks for reporting this. However, we should make sure that add nics supports all the same arguments as create vm, this way it'll be in the same place for supporting multiple IP addresses on a NIC, IPv6, etc.

[leeyc0]

Then would it mean that ipv4_ips should be supported, and not accepting it is it indeed a genuine bug? Because I was told by your support the ipv4_ips is not accepted.

(To be more exact, the ipv4_ips argument is accepted, but simply ignored.)

[rmustacc]

Well, there are a couple different ways to look at this. Today, there is a bug in the documentation, because the endpoint doesn't accept it in a rather unfortunate away (silently ignoring it). In the longer term, as part of other work we are doing, we should make sure that support for specifying addresses here is addresses is added. So whether you want to call the things we haven't built yet a bug or a request for enhancement really just depends on how you want to look at it.