Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate members with the same name #146

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Conversation

justinyaodu
Copy link
Member

  • Upgrade Next.js from 12 to 14
    • Fix some simple usages of Link, opt-in to legacy behavior for others
    • Opt-in to legacy behavior for Image for now
    • Update build command
  • Use TypeScript's satisfies to make type errors easier to understand
  • Create unique IDs for every member instead of using their name, and update usages to match
  • Remove special-case handling of TEST members in alumni view

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for gifted-fermat-a1fc62 ready!

Name Link
🔨 Latest commit 5d8b6c5
🔍 Latest deploy log https://app.netlify.com/sites/gifted-fermat-a1fc62/deploys/655eac8c5679130008c9366c
😎 Deploy Preview https://deploy-preview-146--gifted-fermat-a1fc62.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@navidboloorian navidboloorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@navidboloorian navidboloorian merged commit 1f09955 into main Nov 23, 2023
4 checks passed
@navidboloorian navidboloorian deleted the disambiguate-same-name branch November 23, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants