From 5003d809b147c322192a787240f6519b91e349a7 Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Sat, 21 Sep 2019 19:53:23 +0200 Subject: [PATCH] fixes #74 - dead links to G-2150 and coding-style --- docs/1-introduction/introduction.md | 4 ++-- tools/run-in-container/genpdf.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/1-introduction/introduction.md b/docs/1-introduction/introduction.md index bd20b9ed..87010b71 100644 --- a/docs/1-introduction/introduction.md +++ b/docs/1-introduction/introduction.md @@ -74,11 +74,11 @@ There are basically two types of standards. 1. Non-controversial - These standards make sense. There is no reason not to follow them. An example of this category is [G-2150](../4-language-usage/2-variables-and-types/1-general/g-2150): Avoid comparisons with NULL value, consider using IS [NOT] NULL. + These standards make sense. There is no reason not to follow them. An example of this category is [G-2150](../../4-language-usage/2-variables-and-types/1-general/g-2150): Avoid comparisons with NULL value, consider using IS [NOT] NULL. 2. Controversial - Almost every rule/guildeline falls into this category. An example of this category is [3 space indention](../3-coding-style/coding-style/#rules). - Why not 2 or 4 or even 8? Why not use tabs? You can argue in favor of all these options. In most cases it does not really matter which option you choose. Being consistent is more important. In this case it will make the code easier to read. + Almost every rule/guildeline falls into this category. An example of this category is [3 space indention](../../3-coding-style/coding-style/#rules). - Why not 2 or 4 or even 8? Why not use tabs? You can argue in favor of all these options. In most cases it does not really matter which option you choose. Being consistent is more important. In this case it will make the code easier to read. For very controversial rules, we have started to include the reasoning either as a footnote or directly in the text. diff --git a/tools/run-in-container/genpdf.sh b/tools/run-in-container/genpdf.sh index 64c3c9d6..0f14bb8a 100755 --- a/tools/run-in-container/genpdf.sh +++ b/tools/run-in-container/genpdf.sh @@ -21,8 +21,8 @@ function write_file(){ FILE=$1 echo "" >> ${TARGET_DIR}/docs/index.md sed -e 's/..\/image/image/g' ${DATA_DIR}/docs/${FILE} | \ - sed -e 's|../4-language-usage/2-variables-and-types/1-general/g-2150|#g-2150-avoid-comparisons-with-null-value-consider-using-is-not-null|g' | \ - sed -e 's|../3-coding-style/coding-style/#rules|#rules|g' | \ + sed -e 's|../../4-language-usage/2-variables-and-types/1-general/g-2150|#g-2150-avoid-comparisons-with-null-value-consider-using-is-not-null|g' | \ + sed -e 's|../../3-coding-style/coding-style/#rules|#rules|g' | \ sed -e 's|PLSQL-and-SQL-Coding-Guidelines.pdf||g' | \ sed -e 's/✘/X/g' >> ${TARGET_DIR}/docs/index.md }