Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abi.encodePacked for inputs to keccak256 #102

Open
hswick opened this issue Jun 18, 2018 · 2 comments
Open

Use abi.encodePacked for inputs to keccak256 #102

hswick opened this issue Jun 18, 2018 · 2 comments

Comments

@hswick
Copy link
Contributor

hswick commented Jun 18, 2018

Solidity compiler gives this type of warning quite a bit.
fs.sol:52:20: Warning: This function only accepts a single "bytes" argument. Please use "abi.encodePacked(...)" or a similar function to encode the data.

I believe this is a breaking change in 0.5.0, so it would be good to change this sooner than later.

@Qkyrie
Copy link

Qkyrie commented Jul 5, 2018

Hi @hswick, would it be ok for fundrequest.io to add a tiny bit of funding to this issue, so maybe the community can pick it up?

@hswick
Copy link
Contributor Author

hswick commented Jul 5, 2018

I don’t have a problem with someone else paying for it. As long as we can keep the notifications to a minimum, sometimes these type of services can be really annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants