Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛽ Settle safeTxGas #1139

Merged
merged 2 commits into from
Sep 4, 2023
Merged

⛽ Settle safeTxGas #1139

merged 2 commits into from
Sep 4, 2023

Conversation

akoszowski
Copy link
Contributor

WalletConnectV2 incorrectly passes safeTxGas value, equal 0 (default value).
Thus we have a mismatch between gnosis safeTxHash and one calculated by useDApp (safeTxGasis based on estimation).

This hot fix should be removed after WalletConnectV2 rectifies the problem.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

⚠️ No Changeset found

Latest commit: 63505c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akoszowski akoszowski requested a review from yivlad September 4, 2023 10:37
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 10:42 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 10:42 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 10:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 10:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 10:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 4, 2023 10:56 Inactive
@yivlad yivlad merged commit a02c280 into master Sep 4, 2023
8 checks passed
@yivlad yivlad deleted the ak/settle-safeTxHash-to-zero branch September 4, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants