Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛽ Settle safeTxGas #1139

Merged
merged 2 commits into from
Sep 4, 2023
Merged

⛽ Settle safeTxGas #1139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa884e4
Settle safeTxGas to 0
akoszowski Sep 4, 2023
63505c5
Lint
akoszowski Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/src/helpers/gnosisSafeUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ export const calculateSafeTransactionHash = (
safeTx: SafeTransaction,
chainId: BigNumberish
): string => {
// TODO: Remove after WalletConnectV2 fix
// WalletConnectV2 incorrectly passes safeTxGas value, equal 0 (default value).
// Thus we have a mismatch between gnosis safeTxHash and one calculated by useDApp (safeTxGas is based on estimation)
safeTx = { ...safeTx, safeTxGas: 0 }

return utils._TypedDataEncoder.hash({ verifyingContract: safe.address, chainId }, EIP712_SAFE_TX_TYPE, safeTx)
}

Expand Down
Loading