Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handlebars template fixes #90

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Handlebars template fixes #90

wants to merge 8 commits into from

Commits on Jan 21, 2024

  1. Fix wrong Subscribe/Account button condition 

    The `{{^if @member}}` syntax doesn't seem to be a valid Handlebars.js code. The if/else statement uses `{{#if @member}}`, while the inverse would be `{{#unless @member}}`. In this case, we have both `if` and `else` branches, so we can simply switch them.
    @JanJakes
    JanJakes authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    5c32772 View commit details
    Browse the repository at this point in the history

  2. Fix unmatched tag in signup.hbs 

    There was a closing </ul> tag forgotten in the template, without any corresponding opening tag.
    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    817ea70 View commit details
    Browse the repository at this point in the history

  3. Replace invalid {{^if ...}} with {{#unless ...}}

    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    276ac66 View commit details
    Browse the repository at this point in the history

  4. Remove unmatched closing ")" in sizes attribute

    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    ac31a95 View commit details
    Browse the repository at this point in the history

  5. Use single quotes in helper arguments 

    This improves compatibility with Prettier's `angular` parser.
    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    fb9f737 View commit details
    Browse the repository at this point in the history

  6. Move conditions inside attribute values 

    This improves compatibility with Prettier's `angular` parser.
    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    2c670b1 View commit details
    Browse the repository at this point in the history

  7. Remove tags from comments (they can confuse some parsers) 

    This improves compatibility with Prettier's `angular` parser.
    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e52fd3f View commit details
    Browse the repository at this point in the history

  8. Remove trailing whitespace

    @JanJakes
    JanJakes committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    4798221 View commit details
    Browse the repository at this point in the history