-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide source code lines when reporting breaking changes #574
Comments
Are your specs written in json or yaml? |
We use yaml |
Looks like we may have a way to implement this but it requires some heavy lifting. |
For other people looking at this, here is a demonstration of this limitation: |
Update: |
Is your feature request related to a problem? Please describe.
Currently, breaking change detection provides no source code lines. As a result, the annotations placed in GitHub via the githubactions format are always attached to the first line of the file. This makes it harder than necessary to trace the origin of the problematic source code change.
Describe the solution you'd like
Where possible, detected breaking changes should be associated with the source line of the closes affected concept. For instance, if a mandatory property is removed from a model, then the source code line could be the start of the model or, even better, the line the removal took place.
Describe alternatives you've considered
None
Additional context
None
The text was updated successfully, but these errors were encountered: