-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary (?) calls to Update #178
Comments
I just wanted to clarify that the other update call to possibly remove is the one in TCustomSynEdit.UpdateScrollBars. I've tested with removing this one and the ones in TSynEditScrollBars and so far, I haven't found a case where they're needed. And I totally agree that WM_SETREDRAW (or the new LockDrawing and UnLockDrawing built into TWinControl) works around the issues nicely. However, those extra calls just kind of bother me since I suspect they aren't needed. |
Test for a little while longer and then please submit a PR to close the issue. Remove all calls to Update that are not needed. |
Remove Update call from TCustomSynEdit.UpdateScrollBars, TSynEditScrollBars.WMVScroll and DoMouseWheel.
Discussed in #176
Originally posted by MShark67 February 17, 2022
When I converted the Scrollbar code, I kept the existing Update calls as I didn't want to change any behavior (perhaps ones I didn't understand.) Does anyone know why these are there? They cause issues if you need to load a number of SynEdits in a loop (basically each one will force paint itself, causing slowdowns and flashing.) Removing the calls fixes that issue and I haven't noticed any problems with removing them, but they must be there for a reason I don't know about.
The text was updated successfully, but these errors were encountered: