NexusKitten/moremotion: Replace atan with atan2 #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNin01
added
the
pr: change existing extension
|
Might not need to do a v2 for this |
|
Autolaber failure unrelated to your changes |
|
"direction to" needs a v2 but "point to" does not |
GarboMuffin
approved these changes
Feb 1, 2025
CubesterYT
approved these changes
Feb 1, 2025
DNin01
commented
Feb 1, 2025
| @@ -65,6 +65,7 @@ | |||
| }, | |||
| }, | |||
| extensions: ["colours_motion"], | |||
| hideFromPalette: true, | |||
There was a problem hiding this comment.
@GarboMuffin Oops? I'm pretty sure this block should be visible on the block palette.
There was a problem hiding this comment.
think i have a comment in there that's also wrong, i said old version was 0-360 when its -90-270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages:
Kind of like #1460 but for a different extension.
Of course, the old blocks are still there for backwards compatibility.