Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Buggy DT/Camera with SharkPool/Camera #1885

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

SharkPool-SP
Copy link
Collaborator

@SharkPool-SP SharkPool-SP commented Jan 23, 2025

Resolves #930
Resolves #1839

Remake of DTs buggy camera extension with inspiration from PenguinMods camera extension.

This fixes all known issues with DT's camera. Interpolation support is still yet to be finished but GarboMuffin needs to add a api to allow inserting interpolation data

:)

image

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Jan 23, 2025
@SharkPool-SP
Copy link
Collaborator Author

!format

1 similar comment
@SharkPool-SP
Copy link
Collaborator Author

!format

@SharkPool-SP SharkPool-SP requested a review from a team January 23, 2025 05:16
@hammouda101010
Copy link

can't wait for someone to merge this

@SharkPool-SP
Copy link
Collaborator Author

#1839

@CubesterYT CubesterYT linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

extensions/SharkPool/Camera.js Outdated Show resolved Hide resolved
extensions/SharkPool/Camera.js Outdated Show resolved Hide resolved
extensions/SharkPool/Camera.js Outdated Show resolved Hide resolved
@SharkPool-SP
Copy link
Collaborator Author

!format

@SharkPool-SP
Copy link
Collaborator Author

!format

@gomigg07
Copy link

gomigg07 commented Jan 30, 2025

Just throwing this out there, I think adding a set scroll factor block would work wonders. For example, if the scroll factor in a sprite or clone were set to 0.5 (or 50% going off of Scratch measurements), the sprite would be offset by half the value of the camera's position. Moving the camera 100px to the right displays the sprite only moving 50px to the left. I think it would be useful for parallax effects like scrolling backgrounds.

@SharkPool-SP
Copy link
Collaborator Author

Just throwing this out there, I think adding a set scroll factor block would work wonders. For example, if the scroll factor in a sprite or clone were set to 0.5 (or 50% going off of Scratch measurements), the sprite would be offset by half the value of the camera's position. Moving the camera 100px to the right displays the sprite only moving 50px to the left. I think it would be useful for parallax effects like scrolling backgrounds.

Why not just make a separate camera for that sprite/clone

@gomigg07
Copy link

gomigg07 commented Jan 30, 2025

Why not just make a separate camera for that sprite/clone

Yeah, that's fair. Just figured we could do it like HaxeFlixel does.

@fg133266
Copy link

fg133266 commented Feb 1, 2025

QQ202521-173839.mp4

I'm trying to bind the clone arrow in the video to some specified Camera, but its xy doesn't seem to be accurate, it only works when I try to update the Camera, am I doing something wrong? ;-;

@SharkPool-SP
Copy link
Collaborator Author

QQ202521-173839.mp4

I'm trying to bind the clone arrow in the video to some specified Camera, but its xy doesn't seem to be accurate, it only works when I try to update the Camera, am I doing something wrong? ;-;

Try pausing the arrow movement and setting the camera position to random amounts. Also in the video it's not clear whether the camera x started at 100

@fg133266
Copy link

fg133266 commented Feb 1, 2025

QQ202521-173839.mp4

我正在尝试将视频中的克隆箭头绑定到某个指定的 Camera,但它的 xy 似乎不准确,它仅在我尝试更新 Camera 时有效,是不是我做错了什么? ;-;

尝试暂停箭头移动并将摄像机位置设置为随机量。此外,在视频中,尚不清楚摄像头 x 是否从 100 开始

Snipaste_2025-02-02_06-48-07
Snipaste_2025-02-02_06-56-59

Yes, the x of the camera I set it to 100 at the beginning, and then I added the blocks in the diagram and removed the blocks related to the X movement, and strangely the arrow was at 0 instead of 100

@SharkPool-SP
Copy link
Collaborator Author

QQ202521-173839.mp4

我正在尝试将视频中的克隆箭头绑定到某个指定的 Camera,但它的 xy 似乎不准确,它仅在我尝试更新 Camera 时有效,是不是我做错了什么? ;-;

尝试暂停箭头移动并将摄像机位置设置为随机量。此外,在视频中,尚不清楚摄像头 x 是否从 100 开始

Snipaste_2025-02-02_06-48-07

Snipaste_2025-02-02_06-56-59

Yes, the x of the camera I set it to 100 at the beginning, and then I added the blocks in the diagram and removed the blocks related to the X movement, and strangely the arrow was at 0 instead of 100

I don't understand what you're talking about

@fg133266
Copy link

fg133266 commented Feb 2, 2025

QQ202521-173839.mp4

我正在尝试将视频中的克隆箭头绑定到某个指定的 Camera,但它的 xy 似乎不准确,它仅在我尝试更新 Camera 时有效,是不是我做错了什么? ;-;

尝试暂停箭头移动并将摄像机位置设置为随机量。此外,在视频中,尚不清楚摄像头 x 是否从 100 开始

Snipaste_2025-02-02_06-48-07
Snipaste_2025-02-02_06-56-59
是的,相机的 x 我一开始就把它设置为 100,然后我在图表中添加了块并删除了与 X 运动相关的块,奇怪的是箭头在 0 而不是 100 处

我不明白你在说什么

Oh no, it should be a problem with the translation, sorry;-;

@fg133266
Copy link

fg133266 commented Feb 2, 2025

Snipaste_2025-02-02_11-00-26
I think this should have caused the problem. I'm sorry;-;

@AD1340
Copy link

AD1340 commented Feb 2, 2025

Please...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to backport PenguinMod's Camera Controls?? Mega issue: Camera Controls is a buggy mess
8 participants