Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet 1.0: Removed MultiPolyline and MultiPolygon in LineUtil.Snapping.js #45

Open
nrenner opened this issue Jun 3, 2017 · 0 comments

Comments

@nrenner
Copy link
Contributor

nrenner commented Jun 3, 2017

LineUtil.Snapping.js includes MultiPolyline and MultiPolygon cases, which are removed since Leaflet 1.0:

  • Removed MultiPolyline and MultiPolygon classes since multiple rings are now handled by Polyline and Polygon classes respectively. Layers with multiple rings now perform much better (since each is now physically a single path object instead of being a FeatureGroup of layers).

Changelog 1.0-beta1

It would now need to handle multi-dimensional arrays with Polyline and Polygon. In addition, the instanceof L.Polyline condition also matches Polygons as the Polygon class extends from Polyline.

But I'm wondering if there really is a use-case for snapping to all kinds of geometries.

Still seems to work fine when restricting geometries to LineString like in the osm.html example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant