Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer / url as source #88

Open
PierrickP opened this issue Jul 7, 2016 · 3 comments
Open

Buffer / url as source #88

PierrickP opened this issue Jul 7, 2016 · 3 comments

Comments

@PierrickP
Copy link

I would like to pass a buffer or url to upload()

aws.putObject accept buffer / string / stream http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#putObject-property

Maybe you can change https://github.com/Turistforeningen/node-s3-uploader/blob/master/index.js#L95 to accepte original things passed to src like buffer or stream (with backward compatibility if its a path)

Thanks

@Starefossen
Copy link
Contributor

Hi @PierrickP and thank you for your suggestion! This is something we too would like to have support for, however the tricky part is to pass steams to ImageMagick for processing before they are uploaded 😕

@PierrickP
Copy link
Author

indeed !
I ll check that

@Starefossen
Copy link
Contributor

Great! 😄 Pull requests are always welcome 🚀

You can check out im-metadata and im-resize which wraps the ImageMagick command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants