Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] When trying to parse json everything breaks #205

Closed
BlackTurtle123 opened this issue Aug 23, 2021 · 4 comments
Closed

[BUG] When trying to parse json everything breaks #205

BlackTurtle123 opened this issue Aug 23, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@BlackTurtle123
Copy link

BlackTurtle123 commented Aug 23, 2021 •
edited
Loading

Describe the bug
When enabling advanced features, and then using the json button, the transactions gives a blank screen and many errors

To Reproduce
Steps to reproduce the behavior:

  1. Enable advanced features
  2. Click on json button
  3. Put in the following json
    { "fee": 100000, "description": "testThisUpdate", "type": 17, "version": 1, "assetId": "8yAE9ZMQ1ta1MioWMvQpyUHbiSkqipaCEgkHxuKPJ51L", "name": "BlaDieBloe", }
  4. Click send => blank screen appears and errors (see screenshot)

Expected behavior
The tx should be send

Screenshots
image
image
@BlackTurtle123 BlackTurtle123 added the bug Something isn't working label Aug 23, 2021
@BlackTurtle123
Copy link
Author

relates to #202

@BlackTurtle123
Copy link
Author

Update:
It seems we got a bug were the button gets enabled even with invalid JSON.
And therefor it crashed.

BlackTurtle123 pushed a commit that referenced this issue Nov 17, 2021
#205: add modal output box to get basic info from tx type 17
3356a18
@BlackTurtle123
Copy link
Author

TODO: Icon link is not good yet, not sure what goes wrong

@BlackTurtle123
Copy link
Author

Update: icon should be added.
Issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BlackTurtle123