Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other "buckets" with MilkJarBlock/CowJarBlock #729

Open
jshipley opened this issue Oct 18, 2024 · 1 comment
Open

Support other "buckets" with MilkJarBlock/CowJarBlock #729

jshipley opened this issue Oct 18, 2024 · 1 comment
Labels
compatibility Issues related to compatibility with another mod enhancement New features or improvements to existing features

Comments

@jshipley
Copy link

Various "buckets" (bucketlib buckets, Mekanism fluid tank in bucket mode, and in the near future teapots from SimplyTea, etc) are not able to use the milk jars.

The main problem is that MilkJarBlock::useItemOn() specifically checks for and returns Items.BUCKET and Items.MILK_BUCKET, and any other bucket-like items will be ignored.


I tried to use Balm's useFluidTank method instead of the bucket pickup/place logic in MilkJarBlock::useItemOn(), and it seemed to work fine for filling any fluid handling items (including vanilla buckets) in Forge 1.20 but is not working in Forge/Neoforge 1.21 for some reason.

@jshipley jshipley added the needs discussion This may be considered in the future and I'm looking for more opinions label Oct 18, 2024
@BlayTheNinth BlayTheNinth added compatibility Issues related to compatibility with another mod enhancement New features or improvements to existing features and removed needs discussion This may be considered in the future and I'm looking for more opinions labels Oct 21, 2024
@BlayTheNinth BlayTheNinth moved this to 🎯 Ready for Development in Issues Oct 21, 2024
@BlayTheNinth
Copy link
Member

Is this still an issue in v21.1.3? Milk and Cow jars weren't registered as fluid handlers for NeoForge before which probably played a role.

@BlayTheNinth BlayTheNinth moved this from 🎯 Ready for Development to 📧 On Hold in Issues Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issues related to compatibility with another mod enhancement New features or improvements to existing features
Projects
Status: 📧 On Hold
Development

No branches or pull requests

2 participants