Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushover send-on-resolved not working #688

Open
toskium opened this issue Feb 27, 2024 · 6 comments
Open

Pushover send-on-resolved not working #688

toskium opened this issue Feb 27, 2024 · 6 comments
Labels
area/alerting Related to alerting bug Something isn't working

Comments

@toskium
Copy link

toskium commented Feb 27, 2024

Describe the bug

pushover send-on-resolved seemingly not working.

What do you see?

I receive a pushover notification showing the endpoint being unhealthy

What do you expect to see?

I do not receive a pushover notification when the endpoint is healthy again.

List the steps that must be taken to reproduce this issue

Start the application.
Provoke an alarm.
Wait until success-threshold is exceeded.
No pushover alarm is sent.

Version

5.7.0

Additional information

the relevant parts of my config.yaml look like this:

alerting:
  pushover:
    application-token: mytoken
    user-key: myuserkey

endpoint-internal-defaults: &defaults_internal
  group: internal
  interval: 5m
  client:
    timeout: 10s
    insecure: true
  conditions:
    - "[STATUS] == 200"

endpoints:
  - name: Homepage Dashboard
    <<: *defaults_internal
    url: http://192.168.10.17:3000
    alerts:
      - type: pushover
        failure-threshold: 2
        success-threshold: 2
        send-on-resolved: true
        description: "Healthcheck Failed"
@toskium toskium added the bug Something isn't working label Feb 27, 2024
@Marck
Copy link

Marck commented Jul 11, 2024

@toskium Works like a charm here. The Pushover resolved is send with the same priority as the error one, so maybe you missed the resolved one?
Voting to close this

@amai2012
Copy link

I just migrated from old teams to teams-workflows this week.
And now alerts are still coming, but send-on-resolved is gone.

The alert can be seen in the log, but no indication it wants to send the resolved message...

Maybe there is a generic problem with that message kind.

@amai2012
Copy link

amai2012 commented Nov 4, 2024

I just migrated from old teams to teams-workflows this week. And now alerts are still coming, but send-on-resolved is gone.

The alert can be seen in the log, but no indication it wants to send the resolved message...

Maybe there is a generic problem with that message kind.

I'm checking if that PR is going to fix it for MS Teams Workflows: #883

--> indeed it's fixing my problem.

@TwiN
Copy link
Owner

TwiN commented Nov 20, 2024

The teams-workflows issue seems unrelated to this, as it was just a miss.

As for this pushover issue, at least code-wise, everything seems to be as expected.
The request itself is the same for both when the alert is created and resolved, so that shouldn't be the issue.

@TwiN TwiN added the area/alerting Related to alerting label Nov 20, 2024
@lapers
Copy link

lapers commented Jan 20, 2025

Facing the same problem, where send-on-resolved property makes no effect
Here is my alerting config:

Image

The same behavior for the both telegram and custom POST alerting rules

TwiN added a commit that referenced this issue Jan 20, 2025
@TwiN
Copy link
Owner

TwiN commented Jan 20, 2025

@lapers is there any chance that your endpoint's configuration has a name, group or alert description that has a non-ASCII character?

Also, I just pushed a commit that will log if a request to an alert provider is skipped due to send-on-resolved being set to false. To see it, you'll have to set the log level to debug and use the latest image tag.

TwiN added a commit that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants