Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when OIDC is unavailable #830

Open
xeruf opened this issue Jul 31, 2024 · 3 comments
Open

Crash when OIDC is unavailable #830

xeruf opened this issue Jul 31, 2024 · 3 comments
Labels
area/security Related to security bug Something isn't working wontfix This will not be worked on

Comments

@xeruf
Copy link

xeruf commented Jul 31, 2024

Describe the bug

When OIDC is configured and the OIDC provider is unavailable (can happen transitorily on an upgrade for example), Gatus crashes.

What do you see?

image

What do you expect to see?

Maybe a landing page with an error message, and maybe it can retry a few times?
Also what about a fallback administrative password or something?

List the steps that must be taken to reproduce this issue

No response

Version

5.11

Additional information

No response

@xeruf xeruf added the bug Something isn't working label Jul 31, 2024
@TwiN
Copy link
Owner

TwiN commented Aug 12, 2024

Hmm, this is probably happening because on start, IODC retrieves the .well-known metadata endpoint or something along those lines, and because it's not available, it just fails to initialize...

On one hand, I understand your suggestion, but on the other hand, this should only happen if Gatus' configuration is loading (on start or on hot-reload), and if Gatus is unable to start with the desired configuration, I think the proper behavior should be for Gatus to not start, because otherwise Gatus would be in a state where its running state is not an accurate reflection of its configuration.

It may sound like I'm giving excuses here, but to be honest, the fact that this happens is pretty much a security feature working as intended. If it just fell back to an HTTP basic user/pass prompt or even worse, no authentication at all, I think Gatus would lose a few points as far as compliance goes 😅

@TwiN TwiN added wontfix This will not be worked on area/security Related to security labels Aug 12, 2024
@xeruf
Copy link
Author

xeruf commented Sep 26, 2024

that's why I think a few retries over a few minutes might be the best idea

@TwiN
Copy link
Owner

TwiN commented Sep 27, 2024

Maybe not over a few minutes because I think it's fine to rely on the orchestration mechanism to handle bubble up the issue if the issue lasts for long enough, but I wouldn't be against retrying after the first failure a few seconds later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Related to security bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants