This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Allow graceful termination with status code 1001 #15

Open

kittaakos opened this issue Dec 3, 2019 · 0 comments

kittaakos commented Dec 3, 2019

1001

  1001 indicates that an endpoint is "going away", such as a server
  going down or a browser having navigated away from a page.

Related code:

vscode-ws-jsonrpc/src/socket/reader.ts

Lines 24 to 30 in b9dbfda

    
           if (code !== 1000) { 
        
               const error: Error = { 
        
                   name: '' + code, 
        
                   message: `Error during socket reconnect: code = ${code}, reason = ${reason}` 
        
               }; 
        
               this.fireError(error); 
        
           }

Current behavior: fires on an error with the 1001 status code.
Expected behavior: do not fire error.

The text was updated successfully, but these errors were encountered:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.