Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johanblumenberg fnmock #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LironHazan
Copy link
Collaborator

No description provided.

@LironHazan LironHazan mentioned this pull request Sep 28, 2021
@LironHazan
Copy link
Collaborator Author

@cspotcode I want to merge this PR, wdyt?

@LironHazan
Copy link
Collaborator Author

@johanblumenberg on another topic :)
I really liked that implementation, do you think it's enough to be ported or are there any other functionalities in scope of mocking single fns you've added worth grabbing?

@cspotcode
Copy link
Collaborator

@LironHazan go for it. I won't have much time for ts-mockito so I probably won't be able to do code review, so I say go for it with whatever you have planned.

@roypeled
Copy link
Collaborator

I think that this can be easily achieved with spies, instead of creating a new interface:

const CallbackSpy = spy({ callback: () => 'foobar' });

expect(CallbackSpy.callback()).toHaveBeenCalled()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants