Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal close button needs accessible label #635

Closed
yvonnetangsu opened this issue Jan 27, 2024 · 3 comments · Fixed by #636
Closed

Modal close button needs accessible label #635

yvonnetangsu opened this issue Jan 27, 2024 · 3 comments · Fixed by #636
Labels
enhancement New feature or request released

Comments

@yvonnetangsu
Copy link

Currently, the button to close a modal is an "x" that is announced as "times" by screen readers. This issue could be fixed by adding aria-label="Close" to the <button> element.
@github-actions github-actions bot added the new Flag for new issues before someone replies label Jan 27, 2024
@yvonnetangsu yvonnetangsu mentioned this issue Jan 27, 2024
Merged
@mathio mathio added enhancement New feature or request and removed new Flag for new issues before someone replies labels Jan 29, 2024
mathio added a commit that referenced this issue Jan 29, 2024
@mathio
feat(NOJIRA-123): Add aria-label to modal close button
f75749f 
Resolves #635
@mathio mathio mentioned this issue Jan 29, 2024
Merged
mathio added a commit that referenced this issue Jan 30, 2024
@mathio
feat(NOJIRA-123): Add aria-label to modal close button (#636)
65c36c9 
Resolves #635
typeform-ops-gha pushed a commit that referenced this issue Jan 30, 2024
@semantic-release-bot
chore(release): 4.5.0 [skip ci]
c23ec75 
# [@typeform/embed-v4.5.0](https://github.com/Typeform/embed/compare/@typeform/embed-v4.4.1...@typeform/embed-v4.5.0) (2024-01-30)

### Features

* **NOJIRA-123:** Add aria-label to modal close button ([#636](#636)) ([65c36c9](65c36c9)), closes [#635](#635)
@typeform-ops-gha
Copy link

🎉 This issue has been resolved in version @typeform/embed-v4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mathio
Copy link
Contributor

mathio commented Jan 30, 2024

Hello @yvonnetangsu

thank you for your suggestion. We have just released a new version with aria-label.

Enjoy 👍

@yvonnetangsu
Copy link
Author

Thank you so much for the quick fix @mathio !

@yvonnetangsu yvonnetangsu mentioned this issue Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(NOJIRA-123): Add aria-label to modal close button Typeform/embed
3 participants
@mathio @yvonnetangsu @typeform-ops-gha