-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] A way to know if an embedded typeform is over quota and "closed" #647
Comments
Hello @patcon thank you for the suggestion. I dont know how many customers would be interested in such feature, but I do agree it would be nice to have. Unfortunately I can not promise any timeline, but we will look into it. I like your suggestion to indicate if the form is open in one of the callbacks. This will mitigate any need for server-side implementation on your side, as API endpoints are not available to be called from browser. I think the |
Thanks for thinking on it! I understand the constraint on commiting :) I'll keep tabs on this issue for our next consultation. For now, we'll just close typeform after the gig, and disable it from our app.
Small point of clarification: can't we already use the read endpoint of the Create API without auth from the browser? Like I seem to be able to curl this, so I presume my app could use fetch() on it and get a status there, yeah? Would just be a little off-road, and not actually supported by the Embed SDK in an official way https://api.typeform.com/forms/aYU17R3F
And just to make sure I understand, the possible states seem to be like so:
Does all of the above look right? EDIT2: Seems that 1 & 2 are mutually exclusive states, but 3+4 are the same (this wasn't clear to me at first, sorry) |
It looks like you might know more about this aspect of typeforms than I do @patcon . Good job writing this down. Maybe we could use one of the callbacks ( |
heh thanks :) Just wanted to thoroughly explore for my own understanding, and glad if it helps y'all choose more thoughtfully. All said and done, and additional Thanks you again for thinking on this! |
We'd also see a lot of value in having this. Currently, if there is any error creating the widget (e.g. incorrect form ID), then https://www.typeform.com/explore/ would display within our website. Ideally, we'd want to navigate the user somewhere else on error. Although, it's an unlikely scenario it could occur if we are dynamically injecting the formId, when a/b testing for example. |
@donovantc I think this is different use case, since there is a difference if the form is closed or there is a 404 error 🤔 |
@mathio I guess the issue is that none of the existing callbacks fire if the form cannot be found due to incorrect form Id, unless I'm missing something? Having an This may be different to the case mentioned above. Happy to file a separate issue if that would be better? |
Yes, this is correct. We will need to implement a post message on our side to notify the embed about any errors. |
Hi @patcon I have some good news. We were able to prioritize your feature request and I just opened a PR: #670 The Unfortunately we can not implement this callback for forms that are not published or for invalid URLs (form not found) at this time. I hope this helps your use case. |
Thanks @mathio! This def addresses and improves use-cases like mine in the future :) |
# [@typeform/embed-v5.3.0](https://github.com/Typeform/embed/compare/@typeform/embed-v5.2.0...@typeform/embed-v5.3.0) (2025-01-08) ### Bug Fixes * **TU-21474:** Remove overflow on widget close ([#677](#677)) ([ee4ddf6](ee4ddf6)) ### Features * **TU-20040:** Add `isClosed` to `onReady` callback payload ([#670](#670)) ([f263f9e](f263f9e)), closes [#647](#647)
🎉 This issue has been resolved in version @typeform/embed-v5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi there! Thanks for much for all the maintenance work on this library 🙌
I've been using the iframe embed SDK. We're now putting the app into sleeper mode after running it actively with a plan. Was hoping to opportunististically show the free plan;s typeform when the monthly quota is still there, and otherwise, skip the intake survey. This doesn't seem to be possible from the app that's embedding the typeform.
Things I've checked:
settings.is_public
or otherwise. E.g., https://api.typeform.com/forms/aYU17R3FNeither of these work. But I think this would support users.
Potential solutions are:
onStarted
oronReady
when the form can't be loaded, orI know that I'm now wondering whether other form tools are better for the long-tail after our consultation, to keep collecting slow feedback after our main event. I'll be idly looking to other tools in the future if Typeform can't support this.
Thanks for considering this feature request!
The text was updated successfully, but these errors were encountered: