Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression plotting at training data instead of fine grid #593

Open
trevorcampbell opened this issue Oct 29, 2024 · 1 comment
Open

Regression plotting at training data instead of fine grid #593

trevorcampbell opened this issue Oct 29, 2024 · 1 comment
Labels
bug Issue that needs to be fixed low priority nice but not important or mandatory

Comments

@trevorcampbell
Copy link
Contributor

In the regression chapter in the underfitting/overfitting section, we're plotting predictions at the training data, so when K=1 it looks like a piecewise linear interpolation of the data instead of a piecewise constant function that passes through every point. The fix to this is to plot at a fine grid of predictor points, not the training data.

Todos:

  • fix the bug
  • check for this bug elsewhere in the book
  • check for this bug and similar in the Python book
@trevorcampbell trevorcampbell added low priority nice but not important or mandatory bug Issue that needs to be fixed labels Oct 29, 2024
@trevorcampbell
Copy link
Contributor Author

This impacts the worksheets as well, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that needs to be fixed low priority nice but not important or mandatory
Projects
None yet
Development

No branches or pull requests

1 participant