Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible minor bug in determining location of runs in campaign when work_dir not set #359

Open
d7919 opened this issue Dec 7, 2021 · 1 comment

Comments

@d7919
Copy link
Contributor

d7919 commented Dec 7, 2021

With EasyVVUQ v1.1 installed through pip I found that when not specifying work_dir to Campaign that whilst my campaign database appeared in a sub-directory of the current working directory, the runs appeared under /tmp.

I think the issue is with the below line, which I think should use self.work_dir rather than work_dir?

self._campaign_dir = tempfile.mkdtemp(prefix=name, dir=work_dir)

d7919 added a commit to d7919/EasyVVUQ that referenced this issue Dec 7, 2021
…ting temporary campaign directory

Prior to this change not specifying work_dir would lead to campaign runs appearing under `/tmp` but the database appearing under the current directory. With this change both appear under the current directory.
@d7919
Copy link
Contributor Author

d7919 commented Dec 7, 2021

Possibly also applies to https://github.com/UCL-CCS/EasyVVUQ/blob/dev/easyvvuq/campaign.py#L220

I'm just getting up and running with the code so may be misunderstanding the intent here, but the change given in PR #360 does seem to change runs from appearing under tmp to the expected location under the current directory in my setup.

orbitfold added a commit that referenced this issue Dec 8, 2021
Fix for issue #359 -- use fully expanded work_dir path in creating te…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant