Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CMakelist to incorporate the Python3 CTemplate patch #8

Open
benczaja opened this issue Nov 20, 2023 · 1 comment
Open

update CMakelist to incorporate the Python3 CTemplate patch #8

benczaja opened this issue Nov 20, 2023 · 1 comment

Comments

@benczaja
Copy link
Contributor

Hi Guys,

I see that you have a nice patch for CTemplate/Python3 for the "CPU" version of HemePure. It just simply looks like the same functionality hasn't been migrated to this repo.

Can you also incorporate the Python3 patch for CTemplate in this repo as well.
I think this is useful information for you guys...

https://github.com/UCL-CCS/HemePure/blob/c51d711fb4ede9cc4a54306a13990c5230156dcd/dep/CMakeLists.txt#L201
and
https://github.com/UCL-CCS/HemePure/blob/c51d711fb4ede9cc4a54306a13990c5230156dcd/dep/CMakeLists.txt#L227

And
https://github.com/UCL-CCS/HemePure/blob/master/dep/patches/ctemplate_python3.diff

I don't think that this should be hard to change...
I can open up a PR if that is preferred.
Best,
Ben

@benczaja
Copy link
Contributor Author

See PR #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant