Remove unneeded exception in memory.py #463
Open
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborszita
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #463 +/- ##
=============================================
+ Coverage 91.7% 91.7% +0.1%
=============================================
Files 24 24
Lines 6403 6410 +7
=============================================
+ Hits 5866 5877 +11
+ Misses 537 533 -4 ☔ View full report in Codecov by Sentry. |
fdxmw
reviewed
Jan 18, 2025
| if len(item) > self.addrwidth: | ||
| raise PyrtlError('error, the wire indexing the memory bitwidth > addrwidth') | ||
| addr = item | ||
| addr = as_wires(item, bitwidth=self.addrwidth, truncating=False) |
There was a problem hiding this comment.
Do we need to call as_wires here? It seems like that already happens in __getitem__. If this is needed, consider adding a comment explaining why, otherwise we can remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
The call to
as_wiresis needed in_assignment, tests fail without that.