Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surround non-numeric tsv fields with quotes #90

Open
rcurrie opened this issue Aug 26, 2016 · 2 comments
Open

Surround non-numeric tsv fields with quotes #90

rcurrie opened this issue Aug 26, 2016 · 2 comments
Assignees

Comments

@rcurrie
Copy link
Member

rcurrie commented Aug 26, 2016

Excel will convert text that appears to be a date unless you surround it with quotes leading to all sorts of shenanigan:

http://genomebiology.biomedcentral.com/articles/10.1186/s13059-016-1044-7

By default surround all non-numeric fields (in particular gene names) in tsv files that are downloaded (expression levels tables, gene sets...). Ideally also provide a way to not surround them but this should be harder to get to (default checkbox that's on that says 'Format for Excel')

@rbaertsch
Copy link
Member

Be careful, I worry that ALL fields are non-numeric. How do we currently represent nulls in numeric fields? Are they strings?

On Aug 26, 2016, at 8:21 AM, Rob Currie [email protected] wrote:

Excel will convert text that appears to be a date unless you surround it with quotes leading to all sorts of shenanigan:

http://genomebiology.biomedcentral.com/articles/10.1186/s13059-016-1044-7 http://genomebiology.biomedcentral.com/articles/10.1186/s13059-016-1044-7
By default surround all non-numeric fields (in particular gene names) in tsv files that are downloaded (expression levels tables, gene sets...). Ideally also provide a way to not surround them but this should be harder to get to (default checkbox that's on that says 'Format for Excel')


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #90, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKDixemO9PTZr3Oaj0ozNVWjBn0ei2kks5qjwR6gaJpZM4JuL4c.

@rcurrie
Copy link
Member Author

rcurrie commented Aug 29, 2016

Maybe we just focus on the primary culprits - the gene columns names. If there is anything numeric in a column we leave the entire column as is without quotes.

On Aug 28, 2016, at 12:37 PM, Robert Baertsch [email protected] wrote:

Be careful, I worry that ALL fields are non-numeric. How do we currently represent nulls in numeric fields? Are they strings?

On Aug 26, 2016, at 8:21 AM, Rob Currie [email protected] wrote:

Excel will convert text that appears to be a date unless you surround it with quotes leading to all sorts of shenanigan:

http://genomebiology.biomedcentral.com/articles/10.1186/s13059-016-1044-7 http://genomebiology.biomedcentral.com/articles/10.1186/s13059-016-1044-7
By default surround all non-numeric fields (in particular gene names) in tsv files that are downloaded (expression levels tables, gene sets...). Ideally also provide a way to not surround them but this should be harder to get to (default checkbox that's on that says 'Format for Excel')


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #90, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKDixemO9PTZr3Oaj0ozNVWjBn0ei2kks5qjwR6gaJpZM4JuL4c.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants