Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing tab for current view #134

Closed
i8wu opened this issue Mar 10, 2017 · 1 comment
Closed

Pressing tab for current view #134

i8wu opened this issue Mar 10, 2017 · 1 comment

Comments

@i8wu
Copy link
Collaborator

i8wu commented Mar 10, 2017

Pressing tab for current view sometimes re-renders the view. This is an issue with react-native-tabs/react-native-router-flux, will see if we can get a PR merged into the actual node_module before making forking/hacking a fix into the app.

Needs a fix to node_modules/react-native-tabs/index.js

onSelect(el){
        if (el.props.name === this.props.selected) {
            // do nothing
        }
        else if (el.props.onSelect) {
            el.props.onSelect(el);
        } else if (this.props.onSelect) {
            this.props.onSelect(el);
        }
    }

aksonov/react-native-tabs#51

@i8wu i8wu added bug labels Mar 10, 2017
@i8wu i8wu modified the milestone: Blastoise Mar 28, 2017
@i8wu i8wu removed this from the Blastoise milestone May 2, 2017
@c3bryant c3bryant removed bug labels Aug 25, 2017
@c3bryant
Copy link
Contributor

The pull request has stalled, and this isn't much of an issue since we disabled the tab bar on children views. We will be incorporating an alternative method for handling this behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants