Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARE-103 - Update to Node v18 #129

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

ARE-103 - Update to Node v18 #129

wants to merge 13 commits into from

Conversation

ChisomOguibe11
Copy link
Contributor

What?

Update project to Node version 18.15.0. see jira ticket #ARE-103.
https://collaboration.homeoffice.gov.uk/jira/browse/ARE-103

Why?

Part of Epic to upgrade all HOF services to Node v18. see jira ticket #HOFF-312
https://collaboration.homeoffice.gov.uk/jira/browse/HOFF-312

How?

  • Updated node engine inside package.json from 14.15.0 to 18.12.1
  • Updated main docker image to node:18-alpine
  • Changed all references to node:14 in drone.yml to node:18

Testing?

  • All unit tests + acceptance tests pass
  • Requires testing from QAT team

Screenshots (optional)

Anything Else?

@ChisomOguibe11 ChisomOguibe11 changed the title ARE-103 ARE-103 - Update to Node v18 Mar 23, 2023
Copy link
Contributor

@sulthan-ahmed sulthan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it needs to be tested by QAT before merging, also can you squash the commit and write the commit like Chris beans, happy to help you write the squashed commit

@ChisomOguibe11
Copy link
Contributor Author

Looks good, it needs to be tested by QAT before merging, also can you squash the commit and write the commit like Chris beans, happy to help you write the squashed commit

Thanks Sultan, shall I squash the commits after it's been tested or can I squash them now?

@sulthan-ahmed
Copy link
Contributor

Looks good, it needs to be tested by QAT before merging, also can you squash the commit and write the commit like Chris beans, happy to help you write the squashed commit

Thanks Sultan, shall I squash the commits after it's been tested or can I squash them now?

After QAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants