Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching validators persists across requests #4

Open
daniel-ac-martin opened this issue May 16, 2016 · 3 comments
Open

Patching validators persists across requests #4

daniel-ac-martin opened this issue May 16, 2016 · 3 comments

Comments

@daniel-ac-martin
Copy link
Collaborator

This module patches the validators on a per request basis. Unfortunately, due to the way that hmpo-form-controller works, these patches persist across requests.

For more details see: UKHomeOffice/passports-form-controller#42

@daniel-ac-martin
Copy link
Collaborator Author

My opinion is that fixing this first requires a fix in hmpo-date-controller. Once that is done this module must be updated to reflect the fix.

@daniel-ac-martin
Copy link
Collaborator Author

This could also be fixed by detecting based on the fields config. (Will require some new config.) That is probably a better approach than patching the validators per request even though it requires some more set up.

@daniel-ac-martin
Copy link
Collaborator Author

#5 Will make this the correct approach anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant