Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Enhance Model + Dataset Registration #12

Open
3 tasks
CodyRichter opened this issue Jan 27, 2021 · 0 comments
Open
3 tasks

Enhance Model + Dataset Registration #12

CodyRichter opened this issue Jan 27, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CodyRichter
Copy link
Collaborator

When a model or dataset registers itself to the server currently, it only sends its name and the localhost port it is connecting to currently. The request data is received in the form of a MicroserviceConnection Pydantic object, which can be found in server/dependency.py. When making the changes, you can modify the MicroserviceConnection object and its fields, which will then change what the endpoint can accept.

When these changes are made server-side, equivalent changes should be made in the microservice templates Here and Here

Enhancements that should be made:

  • Instead of sending port, send connection URL. (for example: 'http://localhost:5000' instead of '5000')
  • Add a new description field to describe the microservice that is connected
  • Modify existing usages of the connections to now work with the enhanced data that is being sent.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant