Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove atomic add #21

Open
sctiwari opened this issue May 27, 2017 · 4 comments
Open

Remove atomic add #21

sctiwari opened this issue May 27, 2017 · 4 comments

Comments

@sctiwari
Copy link

Need to remove atomic add. Consuming almost 30% of time.

@KenichiNomura
Copy link
Member

Do you know the 30% is for what grain size? How many atoms/MPIrank?

@sctiwari
Copy link
Author

Total Number of Atom 10752. Program was submitted on 1 KNL nodes with 8 MPI rank and 8 OpenMP thread per rank. No hyper-threading is used.

@KenichiNomura
Copy link
Member

KenichiNomura commented May 29, 2017

So, 1344 atoms/MPIrank with 8 OpenMP threads? I guess the atomic op impacts less on large grain size. It would be nice to investigate it wrt the grain size and # of threads.

EDIT:
I like the idea of removing the atomic ops completely. That'll be beneficial for simulations with small grain size for long time.

@sctiwari sctiwari reopened this May 29, 2017
@ye-luo
Copy link
Collaborator

ye-luo commented May 30, 2017

I think when we go for larger number of threads, the atomic only makes the problem worse.
When we aim large simulations, we tried to keep the number of particles small to reduce time to solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants